On Sat, 31 Oct 2026 10:59:41 GMT, April Ivy <[email protected]> wrote:
>> Larry has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8394260: Address Adler32 AVX2 review comments >> >> Use an unsigned 32-bit type for the division magic constant and update the >> LIMIT overflow comment to refer to the unsigned 32-bit range. >> >> Add an AVX2-specific jtreg run using all-0xFF input around LIMIT. > > src/hotspot/cpu/x86/stubGenerator_x86_64_adler.cpp line 89: > >> 87: const int BASE = 65521; >> 88: const int DIV_BASE_MAGIC_SHIFT = 47; >> 89: const int DIV_BASE_MAGIC = 2147975281U; // gcc magic for unsigned >> divide by 65521 > > Doesn't fit in an `int`, relies on `movl` zero-extending. Could this be > `juint`? The comment above should also say 2^32 unsigned rather than > Integer.MAX_VALUE. Thanks, done; ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4440523375
