On Thu, 13 Aug 2026 23:16:49 GMT, Artur Barashev <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> import cleanup.
>
> src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 452:
>
>> 450: private static void compressG(Block a, Block b, Block dst,
>> 451: boolean xor) {
>> 452: Block blockR = Block.xor(a, b);
>
> Do we really need to allocate a new block on every call here? Reusable
> per-worker buffers would substantially reduce GC pressure and unexpected OOME
> risk.
Let me think more about it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4204164755
