On Mon, 22 Jun 2026 17:35:01 GMT, Valerie Peng <[email protected]> wrote:

>> I myself don't see much benefit to that.
>> 
>> `disconnect()` would still need to keep its current logic. `SCardDisconnect` 
>> still needs to be called in two different circumstances (Cleaner-called 
>> `run()`, and user-called `disconnect()`). I'm not sure the advantage of that 
>> call coming from a new method in `Context`, vs from `disconnect()` directly.
>
> If `Context` can be set to use a different flag than the hardcoded one, then 
> `disconnect()` can be updated to use `Context` instead? This way, the 
> disconnection is always done through `cleanable.clean();` call which I find 
> easier to maintain/understand.

I will look more into it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3470905514

Reply via email to