On Mon, 22 Jun 2026 16:35:00 GMT, Jorn Vernee <[email protected]> wrote:

>> David Simms has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 2822 commits:
>> 
>>  - Merge branch '8317277' into jep401_sub_review_8317279
>>  - Merge remote-tracking branch 'valhalla/lworld' into 8317277
>>  - 8386690: [lworld] cherry-pick JDK-8386124 Test 
>> serviceability/sa/TestG1HeapRegion.java failed: Address of G1HeapRegion does 
>> not match
>>    
>>    Reviewed-by: liach
>>  - 8385743: [lworld] investigate and address build related comments in the 
>> Valhalla PR
>>    
>>    Reviewed-by: liach, erikj
>>  - 8376346: [lworld] Basic Shenandoah support
>>    
>>    Reviewed-by: qamai
>>  - 8386598: [lworld] C1 acmp profiling fix and minor cleanup
>>    
>>    Reviewed-by: mchevalier
>>  - 8386618: [lworld] Remove unused entry_guard_Relocation
>>    
>>    Reviewed-by: chagedorn, jsjolen, jsikstro
>>  - Merge
>>    
>>    Merge jdk-28+2
>>  - 8386623: [lworld] Cleanup module support for system modules in JDK 
>> exploded build with preview resources
>>    
>>    Reviewed-by: liach
>>  - 8386316: [lworld] Replace Valhalla since version with 28
>>    
>>    Reviewed-by: darcy
>>  - ... and 2812 more: https://git.openjdk.org/jdk/compare/6def7d55...426cc065
>
> src/java.base/share/classes/java/lang/invoke/VarHandles.java line 152:
> 
>> 150:                             : new 
>> VarHandleReferences.FieldStaticReadWrite(decl, base, foffset, type, 
>> f.isNullRestricted());
>> 151:                 } else {
>> 152:                     return maybeAdapt(f.isFinal() && 
>> !isWriteAllowedOnFinalFields
> 
> Should the other branches use `maybeAdapt` as well?

Hmm, this diff no longer exists in lworld

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3461741086

Reply via email to