On Thu, 28 May 2026 12:38:05 GMT, Matthew Donovan <[email protected]> wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8375322: Improve DomainKeyStore.java coverage
>
> test/jdk/sun/security/provider/KeyStore/DKSTest.java line 248:
>
>> 246:
>> 247: @Test
>> 248: public void keystoreIsKeyEntryTest() throws Exception {
>
> prefacing every test name with "keystore" is probably unnecessary since the
> whole file is keystore tests. Also, it makes it sound like you're testing
> whether or not a keystore is a "key entry" which sounds strange.
Aggree, removed keystore at the start
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30712#discussion_r3443940820
