On Wed, 17 Jun 2026 05:19:55 GMT, Jan Lahoda <[email protected]> wrote:
>> src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/exec/ExecTerminalProvider.java >> line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2022, 2026, the original author(s). >> >> @lahodaj You probably need to assess the change here and to AbstractPty.java >> to determine whether there is any interaction with the upstream JLine >> project. > > Hm, while we can do changes to the JDK's copy of JLine (e.g. here and > `AbstractPty`), it is better to not to them unless there's a strong reason, > as it make future merges more complicated. And esp. for things that are not > covered by tests, there's always a risk that they may be lost on the merges. > > Maybe this could be brought to https://github.com/jline/jline3, and when it > is included there, it will be adopted by one of the future JLine upgrades (we > usually update to a new version of JLine once in a while)? Thanks! I've reverted the changes to jline3 and I'll follow up with the upstream project to land the changes there. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31487#discussion_r3430895623
