On Wed, 15 Apr 2026 16:43:28 GMT, Mikhail Yankelevich
<[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> additional data cleanup.
>
> src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java
> line 108:
>
>> 106:
>> 107: @Override
>> 108: public boolean equals(Object obj) {
>
> Equals and destroy are also never triggered from what I can see. Do you think
> it would make sense to add a separate test covering these methods?
Ok, I will do this.
> src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 130:
>
>> 128: }
>> 129:
>> 130: private static int checkMax(int value, long max, String errMsg)
>
> This doesn't seem to be used anywhere, should it be removed?
Yes, will remove.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3425561139
PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r3425565433
