On Thu, 28 May 2026 13:24:47 GMT, Matthew Donovan <[email protected]> wrote:
>> This timeout may be caused by different code paths used to resolve
>> `InetAddress.getLoopbackAddress()` in the server thread and
>> `factory.createSocket("localhost",...)` in the client thread. I updated the
>> test to use getLoopbackAddress() for both threads.
>>
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthew Donovan has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains seven additional
> commits since the last revision:
>
> - changed to use Utils.adjustTimeout()
> - Merge branch 'master' into disable-cipher-suites
> - reverted a bunch of changes; changed to use timeout factor for accept()
> call
> - Merge branch 'master' into disable-cipher-suites
> - updated test to enable server thread to exit quickly if client has
> connection error
> - Merge branch 'master' into disable-cipher-suites
> - 8374454: Test
> sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java from
> JDK-8356544 shows intermittent timeouts
test/jdk/sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java
line 56:
> 54: private static final String TLS_PROTOCOL = "TLSv1.2";
> 55: private static volatile int serverPort = 0;
> 56: private static volatile Exception serverException = null;
The `serverException` variable seems never read
test/jdk/sun/security/ssl/CipherSuite/DisabledCipherSuitesNotNegotiated.java
line 137:
> 135:
> 136: private static void runTest(final boolean disabledInClient) throws
> Exception {
> 137: try(ExecutorService executorService =
> Executors.newFixedThreadPool(2)) {
newSingleThreadExecutor() maybe enough.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30680#discussion_r3346696665
PR Review Comment: https://git.openjdk.org/jdk/pull/30680#discussion_r3346680214
