On Fri, 1 May 2026 19:38:03 GMT, Weijun Wang <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> withFactoriesOf
>
> src/java.base/share/classes/java/security/PEMEncoder.java line 366:
>
>> 364: throw new IllegalArgumentException("Error while encoding",
>> e);
>> 365: } finally {
>> 366: KeyUtil.clear(encoding, p8KeySpec);
>
> Do we always clear `encoding` here? There is a chance it's the input
> `privateEncoding` argument.
The intent was this method would clean `privateEncoding`, as the comment says.
But that appears to be inconsistently implemented.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3177371909
