On Tue, 24 Mar 2026 15:53:46 GMT, Hai-May Chao <[email protected]> wrote:
>> The SSLSocketSSLEngineCloseInbound.java test runs with different protocols, >> namely TLSv1.3, TLSv1.2, TLSv1.1, TLSv1, and TLS. The test log file shows >> that it completed successfully for the first four protocols, but it failed >> when running with protocol=TLS. Protocol TLS is resolved to TLSv1.3. The >> failure in the test is a timing-related issue, that server continues with >> write() after the client has already closed its side of the connection. This >> change removes the race condition by synchronizing the client and server >> with CountDownLatch. >> >> Have validated the change to ensure the test to pass (with >> JTREG=REPEAT_COUNT=50). > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Update with Daniel's comment Marked as reviewed by wetmore (Reviewer). test/jdk/sun/security/ssl/SSLSocketImpl/SSLSocketSSLEngineCloseInbound.java line 92: > 90: import javax.net.ssl.SSLSession; > 91: import javax.net.ssl.SSLSocket; > 92: import javax.net.ssl.TrustManagerFactory; I think I recall that if it's more than 5 imports, you could continue using the `.*` to avoid verbose situations like this. It's ok/correct as is, but blech! ;) ------------- PR Review: https://git.openjdk.org/jdk/pull/30340#pullrequestreview-4003640537 PR Review Comment: https://git.openjdk.org/jdk/pull/30340#discussion_r2985478175
