On Fri, 6 Mar 2026 00:43:23 GMT, Shawn Emery <[email protected]> wrote:
>> This change fixes a flaw in DESKeySpec::isWeak when passing a negative
>> number as the offset parameter.
>
> Shawn Emery has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add unit test for negative offsets
src/java.base/share/classes/javax/crypto/spec/DESKeySpec.java line 224:
> 222: throw new InvalidKeyException("null key");
> 223: }
> 224: if (offset < 0) {
I think you should make the same change to the `isParityAdjusted` method and
the constructor, and also similar methods/ctors in `DESedeKeySpec`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30069#discussion_r2895993617
