On Mon, 2 Mar 2026 15:21:18 GMT, Ferenc Rakoczi <[email protected]> wrote:
>> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> comments from Ferenc and Mikhail > > src/java.base/share/classes/sun/security/provider/HSS.java line 947: > >> 945: Objects.requireNonNull(sha256), >> 946: preZi, hashLen, preCandidate, >> 22 + i * n, n); >> 947: } > > I think that the choice between SHA256 and SHAKE would better be done in the > digestFixedLengthPreprocessed() method. > E.g. you can pass it a MessageDigest object that can be initialized in the > lmotsPubKeyCandidate() method to either SHA2.SHA256 or SHA3.SHAKE256Hash and > based on its type digestFixedLengthPreprocessed() could decide what to call. I used Object instead of MessageDigest, but I think the simplification is the same as what you're suggesting. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29833#discussion_r2878801021
