On Wed, 18 Feb 2026 17:55:54 GMT, Kieran Farrell <[email protected]> wrote:
>> The goal of this PR is to add a means of exposing security properties at
>> runtime to aid the debugging security related issues/misconfigurations etc.
>> Currently, only initial security properties set at start up can be exposed
>> via the `InitialSecurityProperty` JFR event.
>>
>> This patch introduces a new jcmd diagnostic command `VM.properties`, which
>> enables developers to print either the current system properties or security
>> properties of a running Java process via command-line arguments (-system or
>> -security). To avoid clutter within the jcmd command list, the old
>> `VM.system_properties` command is hidden, but not removed so will not break
>> existing usages. The implementation of each is shared to reduce duplication.
>
> Kieran Farrell has updated the pull request incrementally with one additional
> commit since the last revision:
>
> newline
src/hotspot/share/services/diagnosticCommand.cpp line 344:
> 342: InstanceKlass* ik = InstanceKlass::cast(k);
> 343: if (ik->should_be_initialized()) {
> 344: ik->initialize(THREAD);
These two space indents are hotspot C++style, we can't change them all to 4
space indents. If you can revert the spaces, it will also make it clearer what
the real changes are.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29124#discussion_r2827284568
