On Tue, 17 Feb 2026 21:10:44 GMT, Ben Perez <[email protected]> wrote:
> I used this format to mirror pmull{2} which has a similar structure.
I take your point. pmull{2} is odd in that the "2" is somewhat redundant in
that it is implied by the types of the operands, so the two versions are
identical apart from assertions. All very weird, but that's Arm's doing.
> Open to changing to the INSN format if that's better though
I'm not sure now. You could at least move the first assertion into `_umullv`.
One thing you should do for sure though is move `_umullv` next to its callers.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27946#discussion_r2819466570
