On Tue, 10 Feb 2026 21:23:26 GMT, Sean Mullan <[email protected]> wrote:

>> Artur Barashev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Correct message name in javadoc
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 969:
> 
>> 967:      * This method only applies to TLSv1.3.
>> 968:      *
>> 969:      * @apiNote The peer needs to support the underlying extension
> 
> Instead of "underlying", say the specific extension so it's clear what needs 
> to be supported, i.e. "compress_certificate extension".
> 
> Also, I would change "needs to" to "must".

Done, thanks!

> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 973:
> 
>> 971:      * to work.
>> 972:      *
>> 973:      * @implNote The SunJSSE provider supports only zlib compression.
> 
> s/supports only/only supports/   (sounds better)

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2790600784
PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2790601510

Reply via email to