On Mon, 9 Feb 2026 11:35:55 GMT, Andrew Dinn <[email protected]> wrote:

>> Ben Perez has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   fixed indexing bug in vs_ldpq, simplified vector loads in 
>> generate_intpoly_assign()
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 7964:
> 
>> 7962:     __ BIND(L_Length14);
>> 7963:     {
>> 7964:       Register a10 = r5;
> 
> It might be nice if these general purpose register operations could be 
> condensed using e.g. an template type RSeq<N> and rs_xxx methods as has been 
> done with the vector register operations. Even better if we could implement 
> RSeq and VSeq as subtypes of a common template type Seq<N, R> with R bound to 
> Register or FloatRegister as a type parameter.
> 
> I'm not suggesting that for this PR but we should look into it via a 
> follow-up PR.

This is a great idea - will explore further after wrapping up this PR

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27946#discussion_r2791270101

Reply via email to