On Mon, 22 Dec 2025 14:30:21 GMT, Weijun Wang <[email protected]> wrote:

>> src/jdk.security.auth/share/classes/jdk/internal/ffi/generated/jaas_unix/package-info.java
>>  line 35:
>> 
>>> 33:  *   echo "#include <spwd.h>" >> $HEADER_NAME
>>> 34:  *
>>> 35:  *
>> 
>> nit: extra line, but please ignore if jextract generated.
>
> Not generated.

Thanks for the comments. I've pushed a new commit that removes all 
jextract-generated code and go fully manual. Is this better?

BTW, I haven't studied the use of `errorno` yet. Also, I have a TODO item at 
the beginning of `UnixLoginModule::login`. Please tell me your opinion on my 
concern.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28931#discussion_r2640097898

Reply via email to