On Wed, 10 Dec 2025 20:43:25 GMT, Sean Coffey <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Only the last few sentences of javadoc are outdated > > src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java line > 261: > >> 259: } >> 260: >> 261: private void findTrustedCertificate(X509Certificate[] chain, > > good to see the refactoring take place. However the `findTrustedCertificate` > method name suggests a return value (for me at least) > > wondering is something like `ensureTrustedCertificate` or similar might be > better for a method returning void ? Usually methods returning value start with `get`, `ensureTrustedCertificate` sounds somewhat vague to me actually. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28275#discussion_r2608196088
