On Sat, 6 Dec 2025 07:22:44 GMT, Bradford Wetmore <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Updates with Weijun's comments
>> - Comments added for possession creation per handshake
>
> src/java.base/share/classes/sun/security/ssl/Hybrid.java line 319:
>
>> 317: }
>> 318:
>> 319: private static byte[] concat(byte[]... inputs) {
>
> @wangweij did the following in `com.sun.crypto.provider.DHKEM.java` and
> `c.s.c.p.HPKE.java`:
>
> private static byte[] concat(byte[]... inputs) {
> ByteArrayOutputStream o = new ByteArrayOutputStream();
> Arrays.stream(inputs).forEach(o::writeBytes);
> return o.toByteArray();
> }
>
> Since this is the third usage in the last couple years, maybe put this in a
> utility class instead and adjust the other instances?
Were you going to update this?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2600274684
