On Mon, 24 Nov 2025 07:51:40 GMT, Hai-May Chao <[email protected]> wrote:

>> Implement hybrid key exchange support for TLS 1.3 by adding three 
>> post-quantum hybrid named groups: X25519MLKEM768, SecP256r1MLKEM768, and 
>> SecP384r1MLKEM1024.
>> Please see [JEP 527](https://openjdk.org/jeps/527) for details about this 
>> change.
>
> Hai-May Chao has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - Update names to uppercase
>  - Remove fallback in engineGeneratePublic
>  - Change default named group list to have only X25519MLKEM768

test/jdk/sun/security/ssl/CipherSuite/DisabledCurve.java line 43:

> 41:         DisabledCurve DISABLE_NONE PASS
> 42:  * @run main/othervm -Djdk.tls.namedGroups="SecP384r1MLKEM1024"
> 43:         DisabledCurve SecP384r1MLKEM1024 FAIL

A different way to enhance this test so that the hybrids are only tested with 
TLS 1.3 would be to add additional optional command-line arguments that take 
the client and server protocols you want to _only_ test with, respectively, ex:


@run main/othervm -Djdk.tls.namedGroups="SecP384r1MLKEM1024"
        DisabledCurve DISABLE_NONE PASS TLSv1.3 TLSv1.3

        
Just for your consideration, if you have time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27614#discussion_r2582077523

Reply via email to