On Mon, 1 Sep 2025 13:09:45 GMT, Mikhail Yankelevich <[email protected]> wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains seven commits: >> >> - Merge branch 'master' into cipher-ffm >> - updated additional Cipher tests for MemorySegment-backed ByteBuffers >> - Merge branch 'master' into cipher-ffm >> - added null-check for arena argument >> - addressed PR comments and refactored to use try-with-resources >> - Merge branch 'master' into cipher-ffm >> - 8357466: Create test for Ciphers that are using ByteBuffers backed by >> MemorySegments > > Looks good, just one comment and a few nitpicks. IMO nits are not worth doing > unless there is another commit. @myankelev , @wangweij , or @fandreuz , any final comments on this PR? If not, please approve, Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/26967#issuecomment-3564321501
