On Tue, 18 Nov 2025 16:48:48 GMT, Sean Coffey <[email protected]> wrote:

>> `SSLLogger` utilizes `System.Logger` if the `javax.net.debug` system 
>> property key value is empty. However, since that class doesn't implement 
>> `SSLogger`, it misses the advantage of highlighting the exact calling site 
>> for each log statement.  Having `SSLLogger `simply implement `System.Logger` 
>> fixes this
>> 
>> I've also taken this opportunity to refractor the `isOn` boolean in 
>> `SSLLogger`. Encapsulated that boolean in a new method which callers can now 
>> use. I also used `ForceInline` directory on that method. Thanks to @dfuch 
>> for suggestions on that front.
>> 
>> Also updated an existing unit testcase to test for the new functionality
>
> Sean Coffey has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review comments from Daniel

Thanks for the reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28376#issuecomment-3556351553

Reply via email to