On Fri, 14 Nov 2025 14:25:45 GMT, Artur Barashev <[email protected]> wrote:
>> Apologies, I meant the tests. `getHostNameInSNI` itself doesn't seem to be >> tested either, so there code will never be tested in the current state. >> Unless there is a test, which I'm just missing > > This is just a refactoring PR. Please file a new ticket if you think > `getHostNameInSNI` needs a unit test. I think it's better to keep things > separate. Refactoring assumes that no new tests needed. Also not sure if we > should test new logging methods, I couldn't find any unit tests for existing > logging methods. Ok, I have created [JDK-8371925 ](https://bugs.openjdk.org/browse/JDK-8371925 ). Will push a pr for it after this pr is closed. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28275#discussion_r2528579023
