On Wed, 12 Nov 2025 18:38:00 GMT, Francisco Ferrari Bihurriet 
<[email protected]> wrote:

>> src/java.base/share/classes/java/security/Security.java line 286:
>> 
>>> 284:                     if (Files.isSameFile(path, activePath)) {
>>> 285:                         throw new InternalError(
>>> 286:                                 "Cyclic include of '" + resolve(path) 
>>> + "'");
>> 
>> Why try to resolve the path for an exception message? If that causes an 
>> exception an `InternalError` will be thrown and this error message will be 
>> lost, making it harder to debug.
>
> Was just for a nicer error message, but I agree it could make things even 
> harder to debug than an unresolved path.
> 
> I will be changing this, adjusting the test case and re-testing.

Done: 40bc832ef22670a6ba2481fb53d2ebe4b3bbd434.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24465#discussion_r2520614612

Reply via email to