On Fri, 31 Oct 2025 17:16:01 GMT, Sean Mullan <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Signatures schemes using sha224 are not available on Windows
>
> src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 424:
>
>> 422: for (String name : config.signatureSchemes) {
>> 423: var ss = SignatureScheme.nameOf(name);
>> 424: if (ss != null) {
>
> The previous code (in `namesOfAvailable()`) also checked if the scheme was
> available before adding it. Did you remove that check because it was
> redundant as the next loop checks that?
Yes, it is redundant, we check it below anyhow.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27961#discussion_r2482175352
