On Sun, 22 Jun 2025 02:30:53 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Several changes are made:
>> 
>> 1. The "include" and "includedir" directives can appear everywhere, even 
>> inside a section or a sub-section. However, it only means the content is 
>> inserted here but the included file still need its own full structure -- 
>> from section to subsections.
>> 2. The same file can be included multiple times as long as not recursively.
>> 3. Everything is merged. For duplicated values, `get` returns the first one 
>> and `getAll` returns all joining by spaces.
>> 
>> Two new tests added. I also separately confirmed that they are parsed in the 
>> same way as [MIT 
>> krb5](https://github.com/krb5/krb5/blob/master/src/util/profile/test_parse.c).
>>  MIT krb5 ignores directory name after "include" but here it's an error.
>
> Weijun Wang has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   another test; no dups clone
>   
>   interdiff impossible; taking evasive action
>   reverted:

Marked as reviewed by valeriep (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/25421#pullrequestreview-2971995565

Reply via email to