On Fri, 27 Jun 2025 17:53:46 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Moved the Key.isDestroyed() check from individual provider SKF impl to
>> JCA SecretKeyFactory class.
>> Changed to throw ISE whenever destroyed key is encountered.
>
> src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java line 85:
>
>> 83: try {
>> 84: if (isDestroyed()) {
>> 85: throw new IllegalStateException("key is destroyed");
>
> nit: for uniformity, you may want to capitalize key since it is capitalized
> elsewhere
Yes, will fix.
> src/java.base/share/classes/com/sun/crypto/provider/PBEKey.java line 209:
>
>> 207: try {
>> 208: if (isDestroyed()) {
>> 209: throw new NotSerializableException("key is destroyed");
>
> nit: for uniformity, you may want to capitalize `key` since it is capitalized
> elsewhere
Yes, will fix.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25632#discussion_r2172962035
PR Review Comment: https://git.openjdk.org/jdk/pull/25632#discussion_r2172961977
