On Wed, 4 Jun 2025 17:43:16 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 506 commits: >> >> - merge latest changes from master branch >> - http3: update H3InsertionsLimitTest to start after receival of client >> settings >> - merge latest changes from master branch >> - quic: separate out the idle termination timer and the STREAM_DATA_BLOCKED >> timer >> - quic: simplify idle timeout management >> - http3: rely on the sole isOpen() method instead of isOpen() and isClosed() >> - quic: do not let h3 idle (in pool) timeout to influence the quic >> transport idle timeout >> - merge latest changes from master branch >> - http3: improve H3ConnectionPoolTest.java >> - Fix snippet >> - ... and 496 more: https://git.openjdk.org/jdk/compare/8d33ea73...d4984d5e > > src/java.net.http/share/classes/jdk/internal/net/http/hpack/ISO_8859_1.java > line 43: > >> 41: // The encoding is simple and well known: 1 byte <-> 1 char >> 42: // >> 43: final class ISO_8859_1 { > > OK - this class is actually used in QPack as well as HPack. Same for the > `QuickHuffman` class below (notice that this is Quick - not Quic ;-) ) > > It might be interesting to investigate if we could pull out these classes to > a common location to break the tie between QPack and HPack. Something to > think about after integration maybe. @AlekseiEfimov I am resolving this conversation now. Something we could think about later! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2166201911
