On Tue, 24 Jun 2025 13:02:45 GMT, Sean Coffey <coff...@openjdk.org> wrote:

> As the original contributor of this test case, it's nice to see the speed up 
> via use of ExecutorService.
> 
> The upper case and lower case property tests are somewhat questionable IMO. 
> One or two lines of test code would suffice but now we have a lot of noise 
> distracting from the original intent of the test code. One could argue that 
> every system property in the JDK could be subject to the same uppercase/lower 
> case testing but such tests don't exist. A few lines of test code can easily 
> verify behavior. Anything else enters the fuzzy logic testing approach. Hope 
> it's not a pattern that new tests have to adopt.

Do you think that keeping it just mixed case would be sufficient? I believe 
this approach might be too much for other tests, it seems to me like a lot for 
this one as well

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25391#issuecomment-3000549169

Reply via email to