On Mon, 24 Mar 2025 20:59:22 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Hi @valeriepeng, I found code assuming `com.sun.crypto.provider.PBEKey` >> contains only ASCII, please find my suggestions in the review comments. I >> also added a suggestion for the tests, in order to increase the coverage in >> that regard. >> >> All the patches are verified to cleanly apply on top of this PR branch, when >> copied through the GitHub's copy button and applied with `xclip -sel clip | >> git apply`. > >> Hi @valeriepeng, I found code assuming `com.sun.crypto.provider.PBEKey` >> contains only ASCII, please find my suggestions in the review comments. I >> also added a suggestion for the tests, in order to increase the coverage in >> that regard. >> >> All the patches are verified to cleanly apply on top of this PR branch, when >> copied through the GitHub's copy button and applied with `xclip -sel clip | >> git apply`. > > Great, thanks for catching this! > Hi @valeriepeng, > > I have left a couple more comments, and taken advantage to do a more complete > review. > > Please note that I haven't finished reviewing `TestPBKD.java` (for example, > we can still do some of the deleted checks). However I wanted to left a > partial review in-advance, as I will be on PTO until next Tuesday. Sure, I will wait for you to complete the review, no hurry. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24068#issuecomment-2759473810
