On Thu, 14 Nov 2024 23:24:33 GMT, Ben Perez <bpe...@openjdk.org> wrote:
>> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme >> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on >> https://github.com/openjdk/jdk/pull/21167 > > Ben Perez has updated the pull request incrementally with one additional > commit since the last revision: > > Updated copyrite, changed classes in ML_DSA_Impls to sealed src/java.base/share/classes/sun/security/provider/ML_DSA.java line 836: > 834: } > 835: > 836: int[][][] generateA(byte[] seed) { I noticed in your generateA method for ML-KEM, that you allocate your 3-dim array as ` short[][][] a = new short[mlKem_k][mlKem_k][];` Since you're going to effectively return all those 3rd dimension arrays you initially allocated back to the GC once you've assigned them all down on line 869, could you do the same thing here? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21364#discussion_r1852623587
