On Sat, 9 Nov 2024 13:50:07 GMT, Lothar Kimmeringer <d...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Set initial cache size > > test/jdk/sun/security/ssl/CipherSuite/TLSCipherSuiteWildCardMatchingIllegalArgument.java > line 47: > >> 45: * class. Thus, we need a separate test class each time we need to modify >> 46: * "jdk.tls.disabledAlgorithms" config value for testing. >> 47: */ > > Still nitpick-level and it might violate coding rules I'm not aware of: > Declaring `wildCardMatch` package visible should allow you to test that > methods's behaviour by simply calling it with fitting parameters in the other > test class. Pass the cache-Map as parameter instead of accessing the "global > variable" in the method and you can additionally test the caching mechanism. Yes, I thought about that as well. But I think modifying method's visibility just to accommodate tests goes against current JDK coding conventions. @seanjmullan May correct me on that. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21841#discussion_r1838263422
