On Wed, 9 Oct 2024 19:07:51 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix decoding non-encrypted types
>
> src/java.base/share/classes/java/security/PEMEncoder.java line 234:
>
>> 232: */
>> 233: public PEMEncoder withEncryption(char[] password) {
>> 234: // PBEKeySpec clones the password
>
> May consider moving this comment to the `@param`.
I'll add a comment to the @param. The code comment here is to make it clear
that doing a clone just creates more copies
> src/java.base/share/classes/sun/security/util/DerValue.java line 1:
>
>> 1: /*
>
> Update copyright year, if required.
date is correct
> src/java.base/share/classes/sun/security/x509/AlgorithmId.java line 1:
>
>> 1: /*
>
> Consider undoing the diff/change to remove the newline, or technically,
> you'll need to update the copyright year, I suppose.
I'll restore the line
> src/java.base/share/classes/sun/security/x509/X509Key.java line 1:
>
>> 1: /*
>
> Update copyright year, if required.
has correct year
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1799854059
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1799878309
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1799879789
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1799850311
