On Mon, 16 Sep 2024 19:21:13 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are 
>> cryptographic algorithms for deriving additional keys from a secret key and 
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   IDE formatting broke snippet

src/java.base/share/classes/javax/crypto/KDF.java line 331:

> 329:      *         if at least one {@code Provider} supports a {@code KDF}
> 330:      *         implementation for the specified algorithm but none of 
> them
> 331:      *         support the specified parameters

I don't understand why this @throws has been removed. @wangweij did you request 
that this be removed? What about the case where there is a provider that 
supports the algorithm, but does not support the parameters? I thought we were 
going to iterate over the providers and try to instantiate each one with the 
supplied parameters. In that case `NoSuchAlgorithmException` is not appropriate.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1765067844

Reply via email to