On Sat, 14 Sep 2024 22:27:36 GMT, Weijun Wang <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine wording on DPS getInstance with params exception
>
> src/java.base/share/classes/javax/crypto/KDF.java line 207:
>
>> 205: * Returns a {@code KDF} object that implements the specified
>> algorithm.
>> 206: *
>> 207: * @see <a href="#DelayedProviderSelection">Delayed Provider
>> Selection</a>
>
> Put `@see` at the end. Put `@implNote` before `@param`. This is the order
> they are rendered in HTML javadoc.
Nit. I don't personally see the merit in this comment, since the renderer knows
what to do, but I've done as you suggest.
> src/java.base/share/classes/javax/crypto/KDF.java line 266:
>
>> 264: * list
>> 265: * @throws NullPointerException
>> 266: * if the {@code algorithm} or {@code provider} is {@code null}
>
> Remove the `the` word. Same below.
This was here to make it read more like proper English, but I'll remove as you
suggest.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761488389
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761487319
