On Fri, 16 Aug 2024 21:07:17 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
>> line 245:
>>
>>> 243: }
>>> 244:
>>> 245: private static boolean isNullOrEmpty(Collection<?> c) {
>>
>> This appears to not be used.
>
> Addressed in
> https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055.
> Please indicate if this is resolved.
resolved
>> src/java.base/share/classes/javax/crypto/KDF.java line 199:
>>
>>> 197:
>>> 198: /**
>>> 199: * Returns a {@code KDF} object that implements the specified
>>> algorithm.
>>
>> This could be considered a CSR comment as well. You may not want to say
>> that this object "implements the specified algorithm". Given the provider
>> implements the algorithm and the provider is delayed initialization. It
>> maybe better to say this "Returns a KDF instance initialized with the
>> specified algorithm."
>> The same applies for other `getInstance()` methods below.
>
> Addressed in
> https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055.
> Please indicate if this is resolved.
resolved
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1723619214
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1723619059
