On Thu, 11 Jan 2024 14:16:09 GMT, Matthias Baesken <[email protected]> wrote:
>> Matthew Donovan has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits since the last revision: >> >> - added additional class to @build tag >> - Merge branch 'master' into pkcs11-ol79 >> - Merge branch 'master' into pkcs11-ol79 >> - added isOracleLinux7() to IGNORED method group in >> TestMutuallyExclusivePlatformPredicates >> - moved isOracleLinux7() method to Platform class >> - simplified logic for determining OL 7 >> - Merge branch 'master' into pkcs11-ol79 >> - cleaned up MultipleLogins.java a little and added copyright date >> - Merge branch 'master' into pkcs11-ol79 >> - Merge branch 'master' into pkcs11-ol79 >> - ... and 1 more: https://git.openjdk.org/jdk/compare/f9115761...eaaabc25 > > test/lib/jdk/test/lib/Platform.java line 354: > >> 352: public static boolean isOracleLinux7() { >> 353: if >> (System.getProperty("os.name").toLowerCase().contains("linux") && >> 354: >> System.getProperty("os.version").toLowerCase().contains("el")) { > > Hi, I checked and the el ("Enterprise Linux" ?) is shown in os.version on > RHEL and Oracle Linux. But how reliable is it? Could this show up also on > some other distros in os.version (maybe in the cpu-related string of uname > output?) ? I'm not aware of any conventions in the output of uname that would prevent other operating systems from including "el" followed by a number. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16547#discussion_r1449002307
