On Wed, 10 Jan 2024 14:17:33 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Sean Mullan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add more comments. Remove unnecessary import. > > src/java.base/share/classes/sun/security/provider/certpath/Builder.java line > 36: > >> 34: import sun.security.provider.certpath.PKIX.BuilderParams; >> 35: import sun.security.util.Debug; >> 36: import sun.security.x509.GeneralNameInterface; > > `GeneralNameInterface` is useless now. Fixed. > src/java.base/share/classes/sun/security/provider/certpath/ForwardBuilder.java > line 556: > >> 554: * @return the common ancestor or null if none or an attribute of >> the >> 555: * last RDN of the common ancestor is geographical >> 556: */ > > ~Is it possible to return the common ancestors of all the 3 names: trusted, > issuer1, issuer2?~ Also, it seems there is no need to return a list. Just a > number is enough. Actually you care about the difference from the common > part, so how about return the distance directly? > > Update: ignore the 1st part of this comment. Fixed as suggested. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17248#discussion_r1448916279 PR Review Comment: https://git.openjdk.org/jdk/pull/17248#discussion_r1448917416
