On Fri, 27 Oct 2023 22:22:46 GMT, Ben Perez <d...@openjdk.org> wrote:

>> Modified `getService` method to prevent caching of `ServiceKey`, which was 
>> negatively impacting multithreaded performance
>
> Ben Perez has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   changed fix to align with bug report

I think the best way to fix this would be what is suggested in the bug: add a 
new property threadId to the ServiceKey class, save the thread id 
(currentThread.getId())  in it in the constructor and add checking it (along 
with the key.matches() check) in the getService() method.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16403#issuecomment-1785395463

Reply via email to