On Thu, 28 Sep 2023 00:54:32 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix exception handling >> - Fix indentation > > src/java.base/share/classes/sun/security/ssl/SSLEngineImpl.java line 1278: > >> 1276: throw >> context.conContext.fatal(Alert.INTERNAL_ERROR, >> 1277: "Unhandled exception", e); >> 1278: } > > Is there any chance this will double alert? Not really. Only the first call to `fatal` sends an alert, subsequent calls just rethrow the given exception, wrapping it in a SSLException if necessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15148#discussion_r1339568493
