On Tue, 19 Sep 2023 23:55:09 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Such a change would apply NSS version number checks to `TestNssDbSqlite` >> which currently doesn't have them. But wait! If `TestNssDbSqlite` has been >> running for years on all NSS versions, then it should be safe to make sqlite >> the default for all tests. > > Yes, for new NSS releases, it should be safe to set sqlite to true by > default. The tests which relies on sqlite like `TestNssDbSqlite` can always > call useSqlite(true) regardless of default. @valeriepeng Thanks for the review! I'll set sqlite to true by default and retest. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15644#discussion_r1331809271
