On Thu, 13 Jul 2023 18:07:54 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which addresses `KeytoolReaderP12Test.java` failing >> for non-English locale users. >> >> This test checks output from keytool, but fails on finding the value 'alias >> name' for non-English locale users. This is because 'alias name' is a >> localized value. (For example, in `ja` this is '別名'). >> >> To fix the failing issue, the keytool process should be ran with >> `-J-Duser.language=en -J-Duser.country=US`. > > Justin Lu has updated the pull request incrementally with two additional > commits since the last revision: > > - Revert spacing changes to KeytoolReaderP12Test.java > - Move English locale params to executeKeytoolCommand Marked as reviewed by lancea (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/14806#pullrequestreview-1529134056
