On Wed, 31 May 2023 05:10:34 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - undo import changes >> - undo import changes > > test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 29: > >> 27: * @library /test/lib >> 28: * @summary SSLEngine throws IAE during parsing of X500Principal >> 29: * @run main/othervm TestBadDNForPeerCA > > Suggestion: > > * @run main/othervm TestBadDNForPeerCA > * @run main/othervm -Djavax.net.debug=all TestBadDNForPeerCA > > and then remove the `debug` field. When we put in the debug field into the template, it was to allow folks to quickly add debugging output to their test, but in general it won't be turned on during regular test runs. > test/jdk/sun/security/ssl/SSLEngineImpl/TestBadDNForPeerCA.java line 160: > >> 158: serverIn = ByteBuffer.allocateDirect(65536); >> 159: >> 160: cTOs = ByteBuffer.allocateDirect(65536); > > not used - you immediately overwrite this value in runTest He updated the Template code but didn't take all of the unused stuff out. I'm ok with it either way. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1211146002 PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1211147351
