On Tue, 16 May 2023 23:42:08 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8301553: Support Password-Based Cryptography in SunPKCS11 (iteration #1)
>>
>> Co-authored-by: Francisco Ferrari <fferr...@redhat.com>
>> Co-authored-by: Martin Balao <mba...@redhat.com>
>
> src/java.base/share/classes/sun/security/util/PBEUtil.java line 62:
>
>> 60: * IvParameterSpec).
>> 61: */
>> 62: public final static class PBES2Params {
>
> nit; static final?
Good
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12396#discussion_r1198223925
