On Mon, 15 May 2023 19:17:18 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> Yes, let's wait for @XueleiFan > > It is not easy to understand the final behavior if throwing SSLException > here. I would like to call `TransportContext.fatal()` directly to make the > behavior more accuracy, by using Alert.DECODE_ERROR. You will need to pass in `TransportContext` as a parameter if you do that, unless you go back changing the callers of `getAuthorities()` to catch `IllegalArgumentException`. I'm now thinking it is better for the callers of `getAuthorities()` to catch `IllegalArgumentException` and then call `fatal`. One other minor comment: - I would remove the word "successfully" as this is a failure case so it is implied. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13466#discussion_r1194286609
