On Fri, 7 Apr 2023 07:47:49 GMT, Eirik Bjorsnos <d...@openjdk.org> wrote:
>> This PR removes the JAR index feature from the runtime: >> >> - `URLClassPath` is updated to remove the `enableJarIndex` system property >> and any code which would be called when this property was `true` >> - The `JarIndex` implementation class is moved into `jdk.jartool` module. >> - The `InvalidJarIndexError` exception class is removed because it falls out >> of use >> - The test `test/jdk/sun/misc/JarIndex/metaInfFileNames/Basic.java` is >> removed because it depends on the JarIndex feature being present >> - The test `test/jdk/sun/misc/JarIndex/JarIndexMergeForClassLoaderTest.java` >> is removed because it depends on the JarIndex feature being present >> - The test `test/jdk/sun/misc/JarIndex/JarIndexMergeTest.java` is removed >> because it end up being the only caller of the JarIndex.merge feature >> - All `JarIndex` methods/constructors which are not used by the `jar -i` >> implementation are removed. >> - `JarIndex` is given package-private access. > > Eirik Bjorsnos has updated the pull request incrementally with one additional > commit since the last revision: > > Add a note in the --help for --generate-index that this option is > deprecated and may be removed in a future release. > It seems the stars are getting aligned for this PR to be integrated. > > None of the current approvals apply to the latest commit > [d04df25](https://github.com/openjdk/jdk/commit/d04df25ea2dd505f2224bff446865a0974a8f37a), > it would be good to have that `jar --help` update approved as well. > > Are there any other concerns left before we can integrate? I think we are good to go. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13158#issuecomment-1501639744
