On Sun, 27 Nov 2022 09:09:23 GMT, Valerie Peng <valer...@openjdk.org> wrote:

>> This RFE enhances existing PBE algorithms with the "SHA512/224" and 
>> "SHA512/256" support. 
>> Current transformation parsing in javax.crypto.Cipher class is re-written to 
>> handle the additional "/" in the "SHA512/224" and "SHA512/256" algorithm 
>> names. Existing tests are updated with the additional new algorithms.
>
> Valerie Peng has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove extra whitespace

src/java.base/share/classes/javax/crypto/Cipher.java line 325:

> 323:          * index 2: padding component (e.g., PKCS5Padding)
> 324:          */
> 325:         String[] parts = { "", "", "" };

1. Do you want to add a test for the 
`PBEWithHmacSHA512/256AndAES_128/CBC/PKCS5Padding` cipher transformation?
2. Is `transformation` case-sensitive?

-------------

PR: https://git.openjdk.org/jdk/pull/11339

Reply via email to