On Tue, 19 Jul 2022 20:55:54 GMT, David Schlosnagle <d...@openjdk.org> wrote:
>> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyrights, apply consistent settings to PermissionsImplies > > test/micro/org/openjdk/bench/java/security/SSLHandshake.java line 56: > >> 54: @Warmup(iterations = 5, time = 1) >> 55: @Measurement(iterations = 5, time = 1) >> 56: @Fork(value = 3) > > should the `@Warmup`, `@Measurement`, and `@Fork` be removed from the > `doHandshake()` benchmark on lines 115-117 below so that these take effect? > > https://github.com/openjdk/jdk/blob/c2cbeb3ee875936c98bb15ec32d692f7d866df76/test/micro/org/openjdk/bench/java/security/SSLHandshake.java#L111-L115 Good observation. This means this benchmark was already tuned, and the pre-existing tuning overrides the setting I thought I was testing with. I've effectively reverted the changes but moved the annotations to class scope for consistency. ------------- PR: https://git.openjdk.org/jdk/pull/9189
