On Mon, 13 Jun 2022 15:44:53 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> At the beginning, this bug was about the incorrect warning message >> "Unsupported authentication scheme" on line 1051 which should have been >> "This key algorithm has been checked, skip it". >> >> Now, it's a code refactoring that emphasizes only the key algorithm inside a >> signature scheme is checked in these two methods, and therefore the >> ignore-if-checked logic in the old code is correct. >> >> Note: `logWarning` is put inside `SSLLogger` so we can get the correct >> caller line number. Also, please advise if the `|| SSLLogger.logWarning` >> style looks weird and if there is a better way to filter and log at the same >> time. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > typo LGTM ------------- Marked as reviewed by jnimeh (Reviewer). PR: https://git.openjdk.org/jdk/pull/9140
