Re: [zfs-discuss] 'zpool history' proposal

2006-05-04 Thread Jeff Bonwick
> Why not use a terse XML format? I suppose we could, but I'm not convinced that XML is stable enough to be part of a 30-year on-disk format. 15 years ago PostScript was going to be stable forever, but today many PostScript readers barf on Adobe-PS-1.0 files -- which were supposed to be the most

Re: [zfs-discuss] 'zpool history' proposal

2006-05-04 Thread Jeff Bonwick
> What I meant is that events that "cause a permanent change..." should > not be deleted from the circular log if there are "old" (older?) > "operationally interesting" events that could be deleted instead. > > I.e., if the log can keep only so much info then I'd rather have the > history of a poo

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Bill Sommerfeld wrote: ... So its really both - the subcommand successfully executes when its actually written to disk and txg group is synced. I found myself backtracking while reading that sentence due to the ambiguity in the first half -- did you mean the write of the literal text of

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Eric Schrock
On Wed, May 03, 2006 at 03:52:39PM -0700, Craig Cory wrote: > I, too, am late to this thread but I caught something that didn't seem right > to me in this specific example. For the administration of the non-global > zones, SunEducation (for whom I am an instructor) is stressing that the ng > zones

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Jason Schroeder
Craig Cory wrote: I, too, am late to this thread but I caught something that didn't seem right to me in this specific example. For the administration of the non-global zones, SunEducation (for whom I am an instructor) is stressing that the ng zones are "Software Virtualizations" (my quotes) and

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Craig Cory
I, too, am late to this thread but I caught something that didn't seem right to me in this specific example. For the administration of the non-global zones, SunEducation (for whom I am an instructor) is stressing that the ng zones are "Software Virtualizations" (my quotes) and that the hardware and

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Edward Pilatowicz
On Wed, May 03, 2006 at 03:05:25PM -0700, Eric Schrock wrote: > On Wed, May 03, 2006 at 02:47:57PM -0700, eric kustarz wrote: > > Jason Schroeder wrote: > > > > >eric kustarz wrote: > > > > > >>The following case is about to go to PSARC. Comments are welcome. > > >> > > >>eric > > >> > > >To piggy

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Eric Schrock
On Wed, May 03, 2006 at 02:47:57PM -0700, eric kustarz wrote: > Jason Schroeder wrote: > > >eric kustarz wrote: > > > >>The following case is about to go to PSARC. Comments are welcome. > >> > >>eric > >> > >To piggyback on earlier comments re: adding hostname and user: > > > >What is the need fo

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Nicolas Williams wrote: On Wed, May 03, 2006 at 01:58:10PM -0400, Bill Sommerfeld wrote: On Wed, 2006-05-03 at 13:40, Nicolas Williams wrote: On Wed, May 03, 2006 at 01:32:27PM -0400, Bill Sommerfeld wrote: 5) I assume that new zfs and zpool subcommands will need to specify whe

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Jason Schroeder wrote: eric kustarz wrote: The following case is about to go to PSARC. Comments are welcome. eric To piggyback on earlier comments re: adding hostname and user: What is the need for zpool history to distinguish zfs commands that were executed by priviledged users in non-g

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Jason Schroeder
eric kustarz wrote: The following case is about to go to PSARC. Comments are welcome. eric To piggyback on earlier comments re: adding hostname and user: What is the need for zpool history to distinguish zfs commands that were executed by priviledged users in non-global zones for those dat

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Nicolas Williams
On Wed, May 03, 2006 at 01:58:10PM -0400, Bill Sommerfeld wrote: > On Wed, 2006-05-03 at 13:40, Nicolas Williams wrote: > > On Wed, May 03, 2006 at 01:32:27PM -0400, Bill Sommerfeld wrote: > > > 5) I assume that new zfs and zpool subcommands will need to specify > > > whether or not they create a

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Nicolas Williams
On Wed, May 03, 2006 at 11:58:43AM -0700, eric kustarz wrote: > >Why not use a terse XML format? It could be extended later as needed > >without affecting tools and can easily accomodate the argv[] array. > > I didn't see a need for it. Do you have a specific example where it > works but what i

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Bill Sommerfeld
On Wed, 2006-05-03 at 14:10, eric kustarz wrote: > Hmm, i'm just taking the argv array and taking each of its entries to > form one string and pass that down. So that's going to potentially > change the whitespace. Why does that matter? potential ambiguity if arguments can contain whitespace.

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Richard Elling wrote: On Wed, 2006-05-03 at 11:10 -0700, eric kustarz wrote: 2) structured or un-structured log information? there are at least two fields now, and potentially more later (if you add the hostname, username, etc.). If it's unstructured, why? if it's structured, how do I get

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Richard Elling
On Wed, 2006-05-03 at 11:10 -0700, eric kustarz wrote: > > 2) structured or un-structured log information? there are at least two > >fields now, and potentially more later (if you add the hostname, > >username, etc.). If it's unstructured, why? if it's structured, how do > >I get at individual f

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Bill Sommerfeld wrote: On Wed, 2006-05-03 at 13:40, Nicolas Williams wrote: On Wed, May 03, 2006 at 01:32:27PM -0400, Bill Sommerfeld wrote: 5) I assume that new zfs and zpool subcommands will need to specify whether or not they create a zpool history entry; is there a general rule her

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Bill Sommerfeld wrote: On Wed, 2006-05-03 at 11:52, eric kustarz wrote: The following case is about to go to PSARC. Comments are welcome. and just so folks outside sun can see what a fast-track review looks like, I'll send my comments here rather than wait for it to show up at PSARC.

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Bill Sommerfeld
On Wed, 2006-05-03 at 13:40, Nicolas Williams wrote: > On Wed, May 03, 2006 at 01:32:27PM -0400, Bill Sommerfeld wrote: > > 5) I assume that new zfs and zpool subcommands will need to specify > > whether or not they create a zpool history entry; is there a general > > rule here going forward? Wor

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Richard Elling
On Wed, 2006-05-03 at 12:40 -0500, Nicolas Williams wrote: > On Wed, May 03, 2006 at 01:32:27PM -0400, Bill Sommerfeld wrote: > > 5) I assume that new zfs and zpool subcommands will need to specify > > whether or not they create a zpool history entry; is there a general > > rule here going forward

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Nicolas Williams
On Wed, May 03, 2006 at 01:32:27PM -0400, Bill Sommerfeld wrote: > 5) I assume that new zfs and zpool subcommands will need to specify > whether or not they create a zpool history entry; is there a general > rule here going forward? Working backwards from your list of "logged" > vs "not logged",

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Bill Sommerfeld
On Wed, 2006-05-03 at 11:52, eric kustarz wrote: > The following case is about to go to PSARC. Comments are welcome. and just so folks outside sun can see what a fast-track review looks like, I'll send my comments here rather than wait for it to show up at PSARC.. (I don't thing absolutely everyt

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Nicolas Williams
On Wed, May 03, 2006 at 10:14:51AM -0700, eric kustarz wrote: > Ed Gould wrote: > >On May 3, 2006, at 8:52, eric kustarz wrote: > > > >>In the future, we are looking to add additional data to log and > >>retrieve, such > >>as hostname (for shared storage) or username (for delegated > >>administra

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
Ed Gould wrote: On May 3, 2006, at 8:52, eric kustarz wrote: In the future, we are looking to add additional data to log and retrieve, such as hostname (for shared storage) or username (for delegated administration). Why not include these in the initial implementation? They both strike m

Re: [zfs-discuss] 'zpool history' proposal

2006-05-03 Thread Ed Gould
On May 3, 2006, at 8:52, eric kustarz wrote: In the future, we are looking to add additional data to log and retrieve, such as hostname (for shared storage) or username (for delegated administration). Why not include these in the initial implementation? They both strike me as important and v

[zfs-discuss] 'zpool history' proposal

2006-05-03 Thread eric kustarz
The following case is about to go to PSARC. Comments are welcome. eric (i'll be going out of town tonight, so apologies if i can't respond immediatley to feedback) A. DESCRIPTION Add the capability of ZFS to log commands to disk (peristently). Only successful commands are logged. At first,